Skip to content

Update Makefile#26

Merged
djjuhasz merged 1 commit intomainfrom
dev/update-makefile
Jan 19, 2026
Merged

Update Makefile#26
djjuhasz merged 1 commit intomainfrom
dev/update-makefile

Conversation

@djjuhasz
Copy link
Contributor

@djjuhasz djjuhasz commented Jan 16, 2026

  • Copy Makefile changes from preprocessing-sfa
  • Fix copy/paste error for "preprocessing-base/internal/enums"
  • Re-order targets alphabetically

@codecov
Copy link

codecov bot commented Jan 16, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.57%. Comparing base (3ce8088) to head (b60a5dd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main      #26       +/-   ##
===========================================
+ Coverage   34.44%   45.57%   +11.12%     
===========================================
  Files           7        6        -1     
  Lines         299      226       -73     
===========================================
  Hits          103      103               
+ Misses        194      121       -73     
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djjuhasz djjuhasz requested a review from Copilot January 16, 2026 22:56
Copilot AI reviewed Jan 16, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Makefile to align it with changes from the preprocessing-sfa project and fixes a copy/paste error where the wrong repository name was referenced in the IGNORED_PACKAGES variable. The targets are also reorganized alphabetically for better maintainability.

Changes:

  • Fixed incorrect repository reference in IGNORED_PACKAGES from "preprocessing-sfa" to "preprocessing-base"
  • Added new fmt target for formatting Go files with golangci-lint
  • Reordered Makefile targets alphabetically (deps before env, list-ignored-packages before list-tested-packages)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

jraddaoui
jraddaoui approved these changes Jan 17, 2026
View reviewed changes
Copy link
Contributor

@jraddaoui jraddaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @djjuhasz! I guess you also thought that it would be nice to use bine in this projects too. There is a few to update, no need to do it right now.

@djjuhasz
Update Makefile
b60a5dd 
- Copy Makefile changes from preprocessing-sfa
- Fix copy/paste error for "preprocessing-base/internal/enums"
- Re-order targets alphabetically
@djjuhasz djjuhasz force-pushed the dev/update-makefile branch from 2e53bd6 to b60a5dd Compare January 19, 2026 16:44
@djjuhasz
Copy link
Contributor Author

djjuhasz commented Jan 19, 2026

@jraddaoui yes it would be nice to add bine for tool management at some point. I just tried to copy to current state of preprocessing-sfa assuming it would be the most up-to-date child workflow because it's the one we use the most, but it doesn't use bine yet either.

@djjuhasz djjuhasz merged commit 35fc7bd into main Jan 19, 2026
7 checks passed
@djjuhasz djjuhasz deleted the dev/update-makefile branch January 19, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@jraddaoui jraddaoui jraddaoui approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@djjuhasz @jraddaoui